|
Post by Exuro on Mar 17, 2008 21:57:49 GMT -5
Yea agreed. Sounds good.
|
|
|
Post by erudan on Mar 18, 2008 1:24:52 GMT -5
Moon, Just a minor point after the Speech Database changes. Export comes up with the following error : -
LunarSphereExport.lua: 99 : attempt to index field '?' (a nil value).
Happy Hunting. ;D:)
|
|
|
Post by Moongaze on Mar 18, 2008 2:54:17 GMT -5
Thanks. I examined the code and, sure enough, it was a typo. This error will occur with the export of global scripts. Although I could be wrong ... Anyway, try not to export global scripts until the next patch. Since the issue doesn't seem to be too harsh, I won't release an patch tonight or tomorrow to fix the issue, but will wait until the Stage 7 release. Until then, a possible fix would be to make the script local (not global) and export it that way. Then, after you load it on the account you want, you can switch it to global. Sorry for the trouble =( If other bugs pop up, I might release another stage 6 version. I have two bug fixes so far, and they appear to be fairly minor ... so we'll see. Thanks again for the info!
|
|
AutolycusWolf
Active Beta Tester
Wolfies just pretend to do naughty things!
Posts: 36
|
Post by AutolycusWolf on Mar 18, 2008 8:46:42 GMT -5
Downloaded version 614 and had the same errors (on my warlock) as the ones I had before...
So I thought "Moon might have forgotten to add the or 0 clause on that line of code he told me to change". That said I opened the .lua file and searched for local reagentCount = GetSpellCount(actionName) in order to add the or 0.
From what I saw you have changed that line of code only with a minor difference: There were two dashes after GetSpellCount(actionName) and before or 0...
So I deleted those two dashes, saved the file, reloaded my UI and all the errors were long gone ;D
|
|
|
Post by Moongaze on Mar 18, 2008 10:33:05 GMT -5
Whoops! ... Thanks for reminding me. I changed the code and was testing some other stuff and forgot to turn it back on. I'll make that change officially again
|
|
AutolycusWolf
Active Beta Tester
Wolfies just pretend to do naughty things!
Posts: 36
|
Post by AutolycusWolf on Mar 19, 2008 13:25:30 GMT -5
Is it a known bug that speeches don't work at all in 614 (not even the default ones) or is it just me? Didn't notice that untill I tried to Soulstone a priest for a heroic run
|
|
|
Post by lothaer on Mar 19, 2008 14:58:01 GMT -5
same here with my resurrect spells.
|
|
|
Post by Moongaze on Mar 19, 2008 16:44:31 GMT -5
I, um ... I'll check that again. Seriously, I fix one thing and blotch another. I was tired these past few days ... I blame the pink elephants that dance on the wall ...
|
|
|
Post by Moongaze on Mar 19, 2008 19:59:43 GMT -5
Well, my speeches work on my end, but it could be due to changes I made on my end before reading that post. Check the speech tab and click on the "settings" for one of your scripts. There should be a spell in the scroll box (not the drop down stuff). If there is, try ctrl-clicking it to delete it and then drag a spell back into the box and try again. If that doesn't work ... I might need your local character's saved variables file for inspection. There might be some bad data that I need to fix =(
If you didn't find a spell there to begin with, that would be the issue, since no spell is assigned to it. I might have done something that wiped that data by accident =) Just checking and see what's up ...
Oh, I'm assuming this is for all scripts? Or are these the scripts that were renamed to numbers?
|
|
AutolycusWolf
Active Beta Tester
Wolfies just pretend to do naughty things!
Posts: 36
|
Post by AutolycusWolf on Mar 20, 2008 10:17:32 GMT -5
While for example the speech tab is functioning as intended on a hunter toon I got (in which I haven't assigned any speeches whatsoever) in all other toons that have a speech library assigned to them, the speech tab is not functioning at all... That is I can't even click on the pulldown menus let along check if a spell is still assigned to a speech...
Dunno what is going on, maybe something that has to do with how the new version is handling the speech libraries?
Whatever the case Moon if you need my saved variables for the toons I have assigned a speech library, let me know and what file(s) you want sent...
UPDATE I logged on my hunter toon again and opened the speech tab... Then I checked the "make script global" setting for all speeches and only then did they appear as selectable on my other toons... When I unchecked them on hunter and some other toons they disappeared from the tab as well... strange really strange...
|
|
|
Post by Moongaze on Mar 20, 2008 13:06:52 GMT -5
So, what I hear is that the scripts worked fine on the hunter, probably because all the scripts were local to that character. The other characters had no scripts on them, or there were scripts, but you couldn't access them with the dropdown menu in the speech tab. You checked "make global" on the hunter scripts so that all the scripts were shared among all the toons and when you logged in to the other toons, they worked fine again. Later, you unchecked "make global" on a toon (For example, "Flying Mount" on the hunter), and when you logged into your other toons, they had all the global scripts that were still global, but no "Flying Mount" script because that script is no longer global and just tied to the hunter. You also set other scripts to no longer be global, and those, too, disappeared from your other toons. If that is what happened, everything is working as intended EXCEPT the beginning, where you couldn't even use the dropdown list and it said stuff was there. Do you remember if the speech tab stated that you had scripts (the little text above the drop down) on a toon, other than the Hunter when you first started? Or did it say "0" ? It sounds like you logged into your hunter first when you got the version 613, which would mean ALL of your scripts in LunarSphere would be assigned, locally, to that toon and removed from all other toons, as which was mentioned in my patch notes. I knew I should have just made the scripts global when I converted everything, but it's a little late for that now =) If a script is global, it will be on all of your toons. If the script is not global, it will be on JUST that toon. If you take a script that WAS global and make it local on your toon, that script will no longer be global and will not be able to be accessed on your other toons... just the toon that has that script now as local. Any of this offer an explaination for what was happening, or a good description of the steps you did? I think it might have been a case of a little confusion due to the way I converted the speech database. Since before version 613, the database was global and all characters used it. When 613 popped out, I let people make scripts global or local to just that character. But, I also made it so that the FIRST character you loaded it up on would retain ALL of the scripts. Kinda dumb move, now that I think about it
|
|
|
Post by Exuro on Mar 20, 2008 14:53:10 GMT -5
so where LS @? is stage 6 over and you started work on stage already? still fixing up the last couple things in stage 6?
|
|
|
Post by Moongaze on Mar 20, 2008 15:19:27 GMT -5
I will be releasing one more patch for stage 6. Probably today. Maybe in an hour. I was hoping for more information about the speech issues, but I personally think it is due to the local/global settings. Either way, I have a few bugs that people mentioned that I took care of. Stage 6 is now finished (save for this patch). I have dragged out some of my old work that I started on Stage 7 and I am currently in the process of implimenting it. I have to test some new memory manager code that I wrote which will make my life a lot easier when it comes to updating code. LunarSphere, in theory, will be smart enough to figure out how much memory each feature takes up without the need for me to manually assign values. Automation is my friend
|
|
|
Post by Moongaze on Mar 20, 2008 18:17:31 GMT -5
Version 615 is now live with the bug fixes. As usual, check the change log thread for details on what I added/changed/fixed in this version. Thanks again! ... I hope this is the last Stage 6 release ... ;D
|
|
AutolycusWolf
Active Beta Tester
Wolfies just pretend to do naughty things!
Posts: 36
|
Post by AutolycusWolf on Mar 21, 2008 9:10:04 GMT -5
Sorry for the late report but with the time difference and all that you get the idea... Anyway with a little messing around I got the idea and yes what you described in your reply post Moon pretty much summarizes what was the case. Since my libraries were a bit messed up though and also beyong any kind of repairing for some reason with all that globalization/localization, I had to delete all my saved variables and re-configure all buttons, menus, speeches, etc from scratch for all my toons and that took me a considerable amount of time (another reason for my late report). So what you described holds true. Every time LS is loaded for the first time on a toon, you get the default scripts etc etc. Still there is an issue the way I see it. Say I mess up with global/local settings (sort of like what I did) and then you want to return things the way they were before. For example you make a script global then you decide to make it local to 2 out of 5 toons you have. If you de-globalize the script ;D from what I understand it will convert to a local script on the toon you were logged into at the time of de-globalization. How can I tie it to another toon if I'm not even able to select it? And how can I spread my speech libraries among my other toons without having to resort to globalization (If I want to have things locally)?
|
|
|
Post by Moongaze on Mar 21, 2008 13:12:15 GMT -5
The import/export feature will do that right now. After you export the data, you'll need to copy the LunarSphereExporter.lua file from your global saved variables folder (World of Warcraft \ WTF \ Account \ (accountname) \ SavedVariables) and place it in your LunarSphere addon folder (overwriting the 0 byte LunarSphereExporter.lua file that exists there. This will make it so you can copy data from one character to another. Then, you hit the import button and every script in there will be applied, locally, to the character. I understand that this is a hastle. It's set up primarily for users who import data from ANOTHER user or computer, not from the same computer. I will be adding another couple lines of code that will load the global LunarSphereExporter.lua file if the local one doesn't exist in the LunarSphere folder. Things to know about the current way the exporter works: 1) It will destroy all export data for the scripts and start with new data when you use Export. The new data will be all scripts that the character has access to (local and global). 2) Right now, in order to use import data, you need to copy the global saved variables file (LunarSphereExporter.lua) to your LunarSphere folder and overwrite the file (typically 0 byte file size, unless you already copied a file there) in order to import from it. In the future, I want to get rid of the import and export button and just have a "script options" button. Clicking that will bring up a window which will let you copy the script (make a duplicate with a new name), export a script (the current script or the whole database), import a script (a specific script or the entire file), and when you are exporting, you can decide to append to the file, or overwrite it. I just haven't gotten that far yet. With these new features, one could copy a global script onto the character with a new name or export the script and then import it onto other characters without the need to copy the saved variable file. Of course, if someone downloads a script file, they will need to place it into the LunarSphere folder to access it
|
|
|
Post by Exuro on Mar 22, 2008 2:12:29 GMT -5
Sorry that I always put my requests in here, but I don't like creating new threads for something simple.
For the memory usage summery. Could you please add a line at the end that totals up the memory of the enabled addons and gives the total?
|
|
|
Post by Moongaze on Mar 22, 2008 2:22:27 GMT -5
Sure, I can add that information, but doesn't WOW show that info when you mouse over the lag/performance bar on the UI? I don't remember if it's the full memory usage (including the WOW UI) or if it just states the addon memory being used. *shrug*
|
|
|
Post by Exuro on Mar 22, 2008 2:54:02 GMT -5
Hmm, I wouldn't know. The only part of the default blizzard UI that I have left is the minimap.
|
|
|
Post by Moongaze on Mar 22, 2008 3:05:07 GMT -5
Good to hear. I'll get that in there with the next version, hehe
|
|