tiolia
Junior Beta Tester
Posts: 13
|
Post by tiolia on Jun 30, 2008 4:28:36 GMT -5
Hello Moongaze, this is only a small suggestion of a cosmetic type. I've a button and submenu filled with pet abilities - as you have given us that nice option ;D. I'd like an additional option to hide/show this button and submenu only when I have a pet summoned. Everytime I mount or walk around without a pet I have 8 empty buttons on my LunarSphere which looks a bit strange Alternatively, you could just hide the buttons that have a pet ability attached, but I guess that's more work as you need to check all three actions of that button first By the way, this happens when playing a warlock, I'm not sure other classes have noticed that behaviour as well.
|
|
|
Post by Moongaze on Jun 30, 2008 14:41:43 GMT -5
For the pet action bar button types, I am actually going to try and set a "if unit exists" condition to the button so that, if the unit "pet" exists, the buttons will be visible. Otherwise, they will be hidden. I was thinking that last night, actually, haha. But, you also bring up a good point about the 3 actions of the button. Unless the hunter (or warlock) makes the middle and right click actions dedicated to actions that require the pet for those buttons, it wouldn't make sense to hide the button. However, it is a little tough to figure out if a spell/item/macro requires a pet in order to use So, I might have to do something like this: 1) If button only has pet action bar actions on it, hide the button if no pet is out. 2) If the button has any OTHER type of assignment for the middle or right clicks (even if it is something like "dismiss pet") ... the button must stay visible. The reasoning for this is that it is a little hard for me to determine if a spell REQUIRES a pet to be out there. That's about all I got, honestly Another option is to add, in the Visibility options part, "Show with pet" and "Hide without pet" options that one could set for the menu button and the submenu buttons. Or "Only show if pet is out" ... I dunno.
|
|
|
Post by Moongaze on Jul 2, 2008 1:32:09 GMT -5
I added the code to make this work, and it will operate as follows:
If a button has a pet ability assigned as a button type of "Pet Action Button 1-10" ... it will show or hide based upon if you have a pet or not. No additional setup or visibility option needed to turn this on. However, here's the catch: If the button has any other actions on it OTHER than a pet bar action (such as, left click is "Pet Action Button 1" and the right click is "Use strongest food" as an example, the button will skip the pet check and operate as any other button. So, the visibility will work ONLY if any and all actions on a button are linked to the pet action bar via the button types I provided.
Here's the fun part. Even if the menu is closed, as soon as your pet comes out, the pet icons will auto-show. The menu, however, would still register as closed, so if you have any other buttons in that menu that are not affected by this visibility issue, they will stay hidden since the menu is closed. Remember the example from above, with the "Use strongest food" on the right click? All the pet buttons BUT the first one would auto-show, because that button is treated like any other button, and since the menu is closed, so is the other normal buttons with it.
To address this, I *could* just make it so if any of the pet action button types are found, it will show/hide as a pet action button, even if you have other button types assigned. This is the assumption that all features of the button are tied to a pet, so there is no reason to show any of it if the pet is out.
I would assume that a users' pet action buttons are kept to one menu, and that menu is dedicated to those actions, so this shouldn't really occur much. However, I know this is not the case at all times, and I will consider just adding a visibility option called "Show only with pet" to the visibility options in the near future. I think this will be more intuitive and will make the user aware that this menu should be used for pet actions.
Right now, the new version of LS that will be coming out soon will have the Pet Action Button 1-10 show/hide stuff that was originally discussed at the top of this post. It will treat "hybrid" buttons (with pet actions and other actions) as normal buttons as well. Later versions will probably remove this feature and be replaced with the visibility option "Show only with pet."
Opinions on this matter? Should I make the visibility setting? Or should I just force the button to show or hide, if AT LEAST one pet action is found?
[edit: I decided to show/hide the button as long as AT LEAST one action is from the pet action bar, instead of requiring any and all actions to be of the pet action bar]
|
|